Add Kubernetes client QPS and Burst configuration support. #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In clusters with many VaultStaticSecrets, the default Kubernetes client QPS of 5 and Burst of 10 is insufficient, leading it to throttle its communications with the Kubernetes API. This can cause brand-new deployments to roll out very slowly as their pods wait for their Kubernetes secrets to be created from their VaultStaticSecrets. This change exposes the operator's Kubernetes client QPS and Burst configuration via cli arguments and environment variables, as well as explicitly via chart values. - adds `--kube-client-qps` and `--kube-client-burst` cli args - adds `VSO_KUBE_CLIENT_QPS` and `VSO_KUBE_CLIENT_BURST` env var support - adds `.Values.controller.manager.kubeClient.qps` and `.burst` to chart - adds chart tests - fixes chart's handling of `.Values.controller.manager.extraEnv` values
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In clusters with many VaultStaticSecrets, the default Kubernetes client QPS of 5 and Burst of 10 is insufficient, leading it to throttle its communications with the Kubernetes API. This can cause brand-new deployments to roll out very slowly as their pods wait for their Kubernetes secrets to be created from their VaultStaticSecrets.
This change exposes the operator's Kubernetes client QPS and Burst configuration via cli arguments and environment variables, as well as explicitly via chart values.
--kube-client-qpsand--kube-client-burstcli argsVSO_KUBE_CLIENT_QPSandVSO_KUBE_CLIENT_BURSTenv var support.Values.controller.manager.kubeClient.qpsand.burstto chart.Values.controller.manager.extraEnvvalues