Take ownership of an existing destination secret #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
09b7d9e to
8dc7c1c
Compare
Adds a new configuration option spec.destination.overwrite that when set to true VSO will replace an existing destination secret that it does not currently own. VSO will then take ownership of the destination secret's life-cycle.
8dc7c1c to
ca485aa
Compare
tvoran
approved these changes
Jan 13, 2024
Comment on lines
+429
to
+432
| wantErr: func(t assert.TestingT, err error, i ...interface{}) bool { | ||
| return assert.ErrorContains(t, err, | ||
| "not the owner of the destination Secret foo/baz") | ||
| }, |
There was a problem hiding this comment.
Does the operator check the type of object that owns a Secret? Just thinking it might be good to allow overwriting ownership if the owner is a non-VSO object, to help when migrating to VSO. Or I suppose it could allow multiple owner references, as long as only one is the VSO object being reconciled.
There was a problem hiding this comment.
I believe with this change VSO will only take ownership of the destination secret if it does not have the generic VSO owner labels.
Allowing other Kinds to own the secret is an interesting idea, but I am not sure how that would work in the case where the "other" Kind is deleted - VSO would probably resolve that on the next reconciliation.
kschoche
approved these changes
Jan 16, 2024
kishoregv
pushed a commit
to kishoregv/vault-secrets-operator
that referenced
this pull request
Feb 12, 2024
Adds a new configuration option spec.destination.overwrite that when set to true VSO will replace an existing destination secret that it does not currently own. VSO will then take ownership of the destination secret's life-cycle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new configuration option
spec.destination.overwritethat when set to true VSO will replace an existing destination secret that it does not currently own. VSO will then take ownership of the destination secret's life-cycle.Closes #337