VDS: remediate deleted destination secret #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the VDS controller did not detect when the destination secret had been deleted after it had initially created it. Fixes: - ensure a deleted destination secret that is owned by the VDS controller results in a re-sync. - add integration test to test this use-case - update all other controller integration tests to test for destination deletion
adrianmoisey
pushed a commit
to adrianmoisey/vault-secrets-operator
that referenced
this pull request
Jan 16, 2024
Previously, the VDS controller did not detect when the destination secret had been deleted after it had initially created it. Fixes: - ensure a deleted destination secret that is owned by the VDS controller results in a re-sync. - add integration test to test this use-case - update all other controller integration tests to test for destination deletion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the VDS controller did not detect when the destination secret had been deleted after it had initially created it.
Fixes:
Closes #228