VSS: Ensure all resource updates are synced. #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, whenever HMACSecretData was set to true and no data drift was detected, the reconciler would skip destination updates, like annotations, labels etc. This change adds tracking of a resource's generation to determine when the reconciler is handling a resource update.
tvoran
approved these changes
Dec 4, 2023
adrianmoisey
pushed a commit
to adrianmoisey/vault-secrets-operator
that referenced
this pull request
Jan 16, 2024
Previously, whenever HMACSecretData was set to true and no data drift was detected, the reconciler would skip destination updates, like annotations, labels etc. This change adds tracking of a resource's generation to determine when the reconciler is handling a resource update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, whenever HMACSecretData was set to true and no data drift was detected, the reconciler would skip destination updates, like annotations, labels etc. This change adds tracking of a resource's generation to determine when the reconciler is handling a resource update.
Closes #472