Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting kv-v2 version for VaultStaticSecret #200

Merged
merged 3 commits into from
May 23, 2023

Conversation

tomhjp
Copy link
Contributor

@tomhjp tomhjp commented May 22, 2023

Adds support for specifying the version of a kv-v2 secret, so that when there are different personas managing the secret contents and the consuming application, they can more easily coordinate rollout and rollback.

@tomhjp tomhjp requested a review from a team May 22, 2023 13:15
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@tomhjp tomhjp merged commit a0f5dd3 into main May 23, 2023
@tomhjp tomhjp deleted the support-kv-v2-version branch May 23, 2023 09:24
@benashz benashz added this to the v0.1.0-beta.1 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants