Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose vmName + vmssName in token metadata #28

Closed
ungureanuvladvictor opened this issue Feb 11, 2020 · 2 comments
Closed

Expose vmName + vmssName in token metadata #28

ungureanuvladvictor opened this issue Feb 11, 2020 · 2 comments

Comments

@ungureanuvladvictor
Copy link
Contributor

Would you be ok exposing the vmName + vmssName in the auth token metadata that gets returned? We have some automation around extracting info from auth tokens in AWS that piggy backs on the instance_id that gets saved via https://github.com/hashicorp/vault/blob/master/builtin/credential/aws/path_login.go#L833 and we're looking into porting this automation to Azure as well but we do not have the info in the auth token returned from the azure auth plugin.

cc: @kalafut, @jefferai, @chrishoffman

@kalafut
Copy link
Contributor

kalafut commented Feb 19, 2020

This seems reasonable to me.

@ungureanuvladvictor
Copy link
Contributor Author

ungureanuvladvictor commented Feb 19, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants