Sync OpenAPI and regenerate: Grand refactor of list handling #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #174 Closes #186 apidiff: ``` Incompatible changes: - (*Auth).GithubReadTeams: removed - (*Auth).GithubReadUsers: removed - (*System).PoliciesList: removed Compatible changes: - (*Auth).GithubListTeams: added - (*Auth).GithubListUsers: added - (*Secrets).CubbyholeList: added - (*Secrets).KvV1List: added - (*Secrets).KvV2ListMetadata: added - (*System).RawList: added - (*System).RawListPath: added ``` (and related changes in schema package)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #174
Resolves #186
apidiff:
(and related changes in schema package)
How has this been tested?
Ad-hoc testing of:
This did surface that various of the KvV1 and Cubbyhole methods are missing
suitable request/response definitions, making them unusable or inconsistent.
Also we may want to consider renaming
KvV2ListMetadatatoKvV2List.Still, this is a step in the right direction.