Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AccTest for tags with dots for Triton provider #7130

Closed
wants to merge 1 commit into from
Closed

Add AccTest for tags with dots for Triton provider #7130

wants to merge 1 commit into from

Conversation

sodre
Copy link
Contributor

@sodre sodre commented Jun 12, 2016

Test will fail on metadata_3 but not on _2 as discussed with @jen20 on 11 June 2016.

- Tests for issue #2143.
- Fixed package names since Triton deprecated the g3-series.
- Must supply SDC_URL when invoking tests.

Test will fail on metadata_3 but not on _2 as discussed with
@jen20 on 11 June 2016.
@jen20
Copy link
Contributor

jen20 commented Jun 12, 2016

Hi @sodre - thanks for the repro here. I'll investigate this and fix it up.

@jen20
Copy link
Contributor

jen20 commented Jun 12, 2016

Tagging this as core and release-0.7 as it's unclear whether this is related to map handling or is provider-specific at this stage.

@jen20
Copy link
Contributor

jen20 commented Jul 12, 2016

Hi @sodre! I've been investigating this and am reasonably sure this isn't a core bug, and is down to something unusual the Triton provider is doing. The thing that makes me relatively sure that there isn't a problem with our core map key handling is this template which plans and applies successfully:

resource "aws_vpc" "test" {
  cidr_block = "10.0.0.0/16"

  tags {
    Name                = "test"
    Thing.Thing2.Thing3 = "test2"
  }
}

And this configuration which also applies successfully:

resource "test_resource" "test" {
  required = "hello"

  required_map = {
    key.key2.key3 = "value"
    key.key4.key5 = "value2"
  }
}

I'm going to keep digging here, but I suspect something in the handling of the tags map in the Triton provider is causing this.

@sodre
Copy link
Contributor Author

sodre commented Jul 12, 2016

@jen20, since you reopened #2143 do you still think this is a Triton specific issue?

@jen20
Copy link
Contributor

jen20 commented Jul 13, 2016

Hi @sodre, it's not Triton specific.

jen20 added a commit that referenced this pull request Jul 14, 2016
@jen20 jen20 mentioned this pull request Jul 14, 2016
@jen20
Copy link
Contributor

jen20 commented Jul 14, 2016

Closed in favour of #7654 - thanks for your work here @sodre!

@jen20 jen20 closed this Jul 14, 2016
@sodre sodre deleted the b-triton-dot-in-tags branch January 26, 2017 07:23
@ghost
Copy link

ghost commented Apr 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants