-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend/azure/update to latest sdks #36258
Open
magodo
wants to merge
19
commits into
hashicorp:main
Choose a base branch
from
magodo:backend/azure/update-to-latest-sdks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Backend/azure/update to latest sdks #36258
magodo
wants to merge
19
commits into
hashicorp:main
from
magodo:backend/azure/update-to-latest-sdks
+1,498
−1,017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-11-09 to 2023-11-03
The failed "Unit Tests" is not related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
azure
backend authentication to match theterraform-provider-azurerm
provider authentication, in several ways:azurerm
provider v4.14.0)The backend configuration logic is updated to match the provider logic. As a result, some new properties are added:
use_cli
use_aks_workload_identity
client_id_file_path
client_certificate
client_id_file_path
client_secret_file_path
One implementation detail is that the using the same Azure storage dataplane SDK, the storage client requires a base URI of the storage account, which is derived by sending a GET to the storage account. This is skipped in case the storage shared access key or sas token is specified, which is to behave identically as the current version.
Also, this PR improves the acctests in following ways:
go test
is big enough to avoid env vars clean for the single process (launched bygo test
) won't interfere the paused tests.Fixes #34322
Target Release
1.11.0
Draft CHANGELOG entry
ENHANCEMENTS
Test