Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ephemeral: render write-only attributes in plan UI #36187

Merged
merged 3 commits into from
Jan 7, 2025
Merged

ephemeral: render write-only attributes in plan UI #36187

merged 3 commits into from
Jan 7, 2025
+365 −6

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Dec 10, 2024 •
edited by jira bot
Loading

Fixes TF-18619

Target Release

1.11.x

Draft CHANGELOG entry

NEW FEATURES | UPGRADE NOTES | ENHANCEMENTS | BUG FIXES | EXPERIMENTS

@DanielMSchmidt DanielMSchmidt force-pushed the TF-18617 branch 2 times, most recently from aee7e70 to 3a962e8 Compare December 12, 2024 09:56
Base automatically changed from TF-18617 to main December 12, 2024 14:59
@DanielMSchmidt DanielMSchmidt force-pushed the TF-18619 branch 2 times, most recently from cf0e19e to 8586fb6 Compare December 12, 2024 16:06
@DanielMSchmidt DanielMSchmidt marked this pull request as ready for review December 13, 2024 08:22
@DanielMSchmidt DanielMSchmidt requested a review from a team as a code owner December 13, 2024 08:22
liamcervante
liamcervante reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@liamcervante liamcervante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, I just think I figured out a way to avoid the double computation of the block action which just saves us some cycles.

internal/command/jsonformat/differ/block.go Outdated Show resolved Hide resolved
liamcervante
liamcervante previously approved these changes Jan 6, 2025
View reviewed changes
internal/command/jsonformat/differ/block.go Outdated Show resolved Hide resolved
@DanielMSchmidt DanielMSchmidt merged commit 276662f into main Jan 7, 2025
11 checks passed
@DanielMSchmidt DanielMSchmidt deleted the TF-18619 branch January 7, 2025 09:19
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamcervante liamcervante liamcervante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielMSchmidt @liamcervante