Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of add support for attributes with nested types in providers schema into v0.15 #28068

Merged

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #28055 to be assessed for backporting due to the inclusion of the label 0.15-backport.

The below text is copied from the body of the original PR.


This PR extends jsonprovider to support attributes with NestedTypes and extends test coverage in jsonprovider and the providers schemas tests. I've also cleaned up some comments and extracted the logic to parse the nesting mode so it can be used in both marshaling blocks and attributes.

Fixes #28050

@teamterraform teamterraform force-pushed the backport/mildwonkey/protocol-schema/poorly-close-titmouse branch from a620ad9 to 54bcbeb Compare March 12, 2021 13:28
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #28068 (54bcbeb) into v0.15 (413f020) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted Files Coverage Δ
command/jsonprovider/block.go 66.66% <41.17%> (+0.95%) ⬆️
command/jsonprovider/attribute.go 92.00% <100.00%> (+5.33%) ⬆️
backend/remote/backend_common.go 50.35% <0.00%> (-0.72%) ⬇️
dag/marshal.go 63.49% <0.00%> (+1.58%) ⬆️
internal/providercache/dir.go 73.46% <0.00%> (+6.12%) ⬆️

@mildwonkey mildwonkey merged commit 4138905 into v0.15 Mar 12, 2021
@mildwonkey mildwonkey deleted the backport/mildwonkey/protocol-schema/poorly-close-titmouse branch March 12, 2021 15:10
@ghost
Copy link

ghost commented Apr 12, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants