Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: Remove duplicate code from SchemaMerger #95

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

radeksimko
Copy link
Member

I was a little too trigger happy when merging #94 😅

So this is to address @dbanck 's valid point about some duplicate code there.

@radeksimko radeksimko requested a review from dbanck February 24, 2022 18:54
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radeksimko radeksimko merged commit faadc57 into main Feb 25, 2022
@radeksimko radeksimko deleted the remove-duplicate-code branch February 25, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants