Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set IsSensitive in variable schema #55

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

beandrad
Copy link
Contributor

@beandrad beandrad commented Jun 9, 2021

So that terraform-ls can return information about whether a variable
value is sensitive.

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

Can you also reflect the sensitivity flag in the provider schema, please?

cAttrs[name] = &schema.AttributeSchema{
Description: markupContent(attr.Description, attr.DescriptionKind),
IsDeprecated: attr.Deprecated,
IsComputed: attr.Computed,
IsOptional: attr.Optional,
IsRequired: attr.Required,
Expr: exprConstraintsFromAttribute(attr),
}

@beandrad
Copy link
Contributor Author

beandrad commented Jun 9, 2021

That was fun :D

So that terraform-ls can return information about whether a variable
value is sensitive.
@beandrad beandrad force-pushed the ia.vars-issensitive branch from 574cfd4 to 68db393 Compare June 9, 2021 14:53
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@radeksimko radeksimko merged commit 8f28989 into hashicorp:main Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants