Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: proper version checking for v1.31.2 version testing #2620

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Nov 14, 2024

The branch check was not done correctly. This PR corrects the mistake from #2619

GHA runs can be found here:

Checks for main, runs all k8s versions except for v1.31.2: https://github.com/BBBmau/terraform-provider-kubernetes/actions/runs/11844946716

Checks for v3-main-release, all k8s version including v1.31.2 are ran: https://github.com/BBBmau/terraform-provider-kubernetes/actions/runs/11844947578

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@BBBmau BBBmau requested a review from a team as a code owner November 14, 2024 20:28
@BBBmau BBBmau requested a review from jrhouston November 14, 2024 20:28
Copy link
Contributor

@JaylonmcShan03 JaylonmcShan03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this :)

@BBBmau BBBmau merged commit 507a1f3 into hashicorp:main Nov 14, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants