Fix restart_policy validation in Deployment

[alexsomesan]

Description

Fixes validation of restart_policy values in Deployment's pod template - only "Always" is a valid value in this case

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=^TestAccKubernetesDeploymentV1_with_restart_policy'
=== RUN   TestAccKubernetesDeploymentV1_with_restart_policy
=== PAUSE TestAccKubernetesDeploymentV1_with_restart_policy
=== CONT  TestAccKubernetesDeploymentV1_with_restart_policy
--- PASS: TestAccKubernetesDeploymentV1_with_restart_policy (12.22s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   13.430s

Release Note

Release note for CHANGELOG:

resource/kubernetes_deployment_v1: Fix validation of `restart_policy` values

References

Fixes #2591

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[SarahFrench]

After reading through the original issue the code changes in this PR make sense, and I can see the new acc test passed.

Are there plans to make the field accept the other 2 values in the future? Or is making the pods always restart a way to ensure we're keeping everything declarative and predictable?

Also, I saw some unrelated acceptance tests failed- could you confirm that they're unrelated before merging?