Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in manifest documentation #2359

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Fix typo in manifest documentation #2359

merged 4 commits into from
Dec 4, 2023

Conversation

SarahFrench
Copy link
Member

@SarahFrench SarahFrench commented Dec 4, 2023 •
edited
Loading

Description

Fixes a typo picked up in automation

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

NONE.

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@SarahFrench SarahFrench requested a review from a team as a code owner December 4, 2023 10:23
@SarahFrench
Copy link
Member Author

SarahFrench commented Dec 4, 2023 •
edited
Loading

Fixing a typo caused the checks to identify more issues in the file

Edit: and after pushing the second commit I got some new lint errors reported 😮‍💨

arybolovlev
arybolovlev approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ✍🏻

@SarahFrench SarahFrench merged commit 61f5e65 into main Dec 4, 2023
7 checks passed
@SarahFrench SarahFrench deleted the SarahFrench-misspelling branch December 4, 2023 13:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arybolovlev arybolovlev arybolovlev approved these changes

Assignees
No one assigned
Labels
documentation pr/no-changelog size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SarahFrench @arybolovlev