Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split GH workflows #2357

Merged
merged 11 commits into from
Dec 6, 2023
Merged

Split GH workflows #2357

merged 11 commits into from
Dec 6, 2023

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented Nov 30, 2023 •
edited
Loading

Description

This PR separates unit test workflow from checkers and linters. In addition to that, it updates acceptance test workflows to run only acceptance tests by default.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

KinD https://github.com/hashicorp/terraform-provider-kubernetes/actions/runs/7045409614

Release Note

Release note for CHANGELOG:

NONE.

References

Fix: #2356

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

arybolovlev
arybolovlev commented Nov 30, 2023
View reviewed changes
website/docs/r/manifest.html.markdown Outdated

- Fields of objects are addressed with `.`
- Keys of a map field are addressed with `["<key-string>"]`
- Elements of a list or tuple field are addressed with `[<index-numeral>]`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a linter complaint fix.

@arybolovlev arybolovlev marked this pull request as ready for review November 30, 2023 10:55
@arybolovlev arybolovlev requested a review from a team as a code owner November 30, 2023 10:55
SarahFrench
SarahFrench approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a proper look through the changes now and I'm happy to approve.

If possible, it'd be great to rename that workflow file (see other comment) but that doesn't affect how it functions.

@arybolovlev arybolovlev merged commit eae8fa7 into main Dec 6, 2023
6 checks passed
@arybolovlev arybolovlev deleted the update-gh-workflows branch December 6, 2023 11:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SarahFrench SarahFrench SarahFrench approved these changes

Assignees
No one assigned
Labels
pr/no-changelog size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split checks on PRs so acceptance tests and unit tests run separately
2 participants
@arybolovlev @SarahFrench