Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Fix for #46 and probably #54 #55

Merged
merged 3 commits into from
Jun 11, 2020
Merged

Conversation

jan-eat
Copy link
Contributor

@jan-eat jan-eat commented Jun 4, 2020

Description

Successfully authenticated to GKE by including the auth plugin from client-go.
Inspired by kubernetes/client-go#242

Also downgraded the version of gnostic to 0.4.0, as the code does not build with 0.4.1 due to kubernetes/client-go#741

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch? (If so, please include the test log in a gist)

References

Addressed #46 (tested) and probably #54.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

jan-eat added 2 commits June 5, 2020 01:13
kubernetes/client-go#741
Can upgrade to 0.4.2 once kubernetes 1.19 is released.
inspired by kubernetes/client-go#242

appears to resolve hashicorp#46

probably also fixes hashicorp#54
@hashicorp-cla
Copy link

hashicorp-cla commented Jun 4, 2020

CLA assistant check
All committers have signed the CLA.

@jan-eat
Copy link
Contributor Author

jan-eat commented Jun 4, 2020

I think I properly identified the fix to the issue here, but am not sure if I placed the fix in the right place etc. Have not spent enough time with the codebase to understand it and am not a go pro.

@aareet aareet linked an issue Jun 5, 2020 that may be closed by this pull request
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jan-eat. The change looks good to me.
I wasn't aware of the problem with gnostic. Good catch there!

@alexsomesan alexsomesan merged commit 553115f into hashicorp:master Jun 11, 2020
@jbrambleDC
Copy link

Could we get this out in a release? Looks like last release was more than 11 days ago.

@aareet
Copy link
Contributor

aareet commented Jun 25, 2020

@jbrambleDC we're working on it in #68 :) A previous commit broke our build process so we're working to get that fixed. In the meantime running make install on a checkout of the master branch should give you these fixes to test with. More info on building the provider at https://github.com/hashicorp/terraform-provider-kubernetes-alpha/blob/master/_about/CONTRIBUTING.md

@ghost
Copy link

ghost commented Jul 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support discrete credentials in provider configuration.
5 participants