Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain TF >= 0.12 Compatibility with v3.0.0 #161

Merged
merged 16 commits into from
Jul 27, 2022
Merged

Conversation

bendbennett
Copy link
Contributor

@bendbennett bendbennett marked this pull request as ready for review July 14, 2022 10:19
@bendbennett bendbennett requested a review from a team as a code owner July 14, 2022 10:19
@bendbennett bendbennett added this to the v3.0.0 milestone Jul 14, 2022
@github-actions github-actions bot added size/L and removed size/M labels Jul 18, 2022
bendbennett and others added 3 commits July 18, 2022 13:24
…162)

* Bump github.com/hashicorp/terraform-plugin-go from 0.11.0 to 0.12.0

Bumps [github.com/hashicorp/terraform-plugin-go](https://github.com/hashicorp/terraform-plugin-go) from 0.11.0 to 0.12.0.
- [Release notes](https://github.com/hashicorp/terraform-plugin-go/releases)
- [Changelog](https://github.com/hashicorp/terraform-plugin-go/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-plugin-go@v0.11.0...v0.12.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/terraform-plugin-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump terraform-plugin-sdk to v2.19.0

* Bump terraform-plugin-framework to v0.10.0

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Benjamin Bennett <ben.bennett@hashicorp.com>
Copy link
Contributor

@detro detro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bendbennett bendbennett requested a review from bflad July 25, 2022 13:15
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things, otherwise looks good to me 🚀

@bendbennett bendbennett merged commit bfc445a into main Jul 27, 2022
@bendbennett bendbennett deleted the bendbennett/issues-160 branch July 27, 2022 11:03
Comment on lines +9 to +11
* data-source/http: Response status code is not checked anymore. A new read-only attribute, `status_code`, has been added. It can be used either with
[precondition and postcondition](https://www.terraform.io/language/expressions/custom-conditions#preconditions-and-postconditions) checks (Terraform >= 1.2.0), or, for instance,
with [local-exec Provisioner](https://www.terraform.io/language/resources/provisioners/local-exec) ([114](https://github.com/hashicorp/terraform-provider-http/pull/114)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👩‍🍳 💋

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StateFunc cannot be used within a TypeSet in 0.12
3 participants