Skip to content

Commit

Permalink
Only run OCI login on create and update (#846)
Browse files Browse the repository at this point in the history
Read and delete operations do not require access to the actual chart,
so we don't need to login. Removing this prevents issues on refresh for
short-living, rotated credentials as e.g. used by Amazon ECR.
  • Loading branch information
mKeRix authored Apr 10, 2022
1 parent 9d162fb commit eeba9bf
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions helm/resource_release.go
Original file line number Diff line number Diff line change
Expand Up @@ -418,10 +418,6 @@ func resourceReleaseRead(ctx context.Context, d *schema.ResourceData, meta inter
if err != nil {
return diag.FromErr(err)
}
err = OCIRegistryLogin(c, d)
if err != nil {
return diag.FromErr(err)
}

name := d.Get("name").(string)
r, err := getRelease(m, c, name)
Expand Down Expand Up @@ -684,10 +680,6 @@ func resourceReleaseDelete(ctx context.Context, d *schema.ResourceData, meta int
if err != nil {
return diag.FromErr(err)
}
err = OCIRegistryLogin(actionConfig, d)
if err != nil {
return diag.FromErr(err)
}

name := d.Get("name").(string)

Expand Down Expand Up @@ -927,10 +919,6 @@ func resourceReleaseExists(d *schema.ResourceData, meta interface{}) (bool, erro
if err != nil {
return false, err
}
err = OCIRegistryLogin(c, d)
if err != nil {
return false, err
}

name := d.Get("name").(string)
_, err = getRelease(m, c, name)
Expand Down

0 comments on commit eeba9bf

Please sign in to comment.