Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HCP Log Streaming Destination Resource #719

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Update HCP Log Streaming Destination Resource #719

merged 2 commits into from
Jan 10, 2024

Conversation

leahrob
Copy link
Contributor

@leahrob leahrob commented Jan 10, 2024 •
edited by jira bot
Loading

IFACE-2448

  • update endpoint in docs with correct format
  • update the token attribute to “sensitive” so the TF cli output obscures the token

🛠️ Description

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

@leahrob leahrob marked this pull request as ready for review January 10, 2024 18:42
@leahrob leahrob requested a review from a team as a code owner January 10, 2024 18:42
@leahrob leahrob added the pr/no-changelog Auto-pinning label Jan 10, 2024
@leahrob leahrob merged commit 2ee5387 into main Jan 10, 2024
5 of 6 checks passed
@leahrob leahrob deleted the update-log-streaming-dest-resource branch January 10, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binarymatt binarymatt binarymatt approved these changes

@cdransf cdransf cdransf approved these changes

@janet janet janet approved these changes

Assignees
No one assigned
Labels
pr/no-changelog Auto-pinning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leahrob @binarymatt @cdransf @janet