Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove suffix ( - HCP Provider) from page name of guides #710

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Remove suffix ( - HCP Provider) from page name of guides #710

merged 4 commits into from
Jan 18, 2024

Conversation

jasonpilz
Copy link
Member

@jasonpilz jasonpilz commented Dec 19, 2023 •
edited
Loading

🛠️ Description

  • Currently the nav shows a suffix for each Guide name, - HCP Provider. Since these page names are already nested under hcp provider, this is redundant and adds distraction.
  • Removes those suffixes and regenerate the docs.
  • Adds a new peering guide page for Azure, including Hub & Spoke architectures and examples.
Screenshot 2023-12-19 at 12 10 58 PM

@jasonpilz jasonpilz added the pr/no-changelog Auto-pinning label Dec 19, 2023
@jasonpilz jasonpilz self-assigned this Dec 19, 2023
@jasonpilz jasonpilz requested review from a team as code owners December 19, 2023 22:46
aidan-mundy
aidan-mundy approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@aidan-mundy aidan-mundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@jasonpilz
Azure Peering Guide (#712)
42164ed 
* Stub azure peering guide

* Move AWS peering guide files into separate organization

* Stub Azure terraform config files for peering guide

* Remove data source note from peering resource

* Base Azure Peering guide

* Add Azure gateway example to Azure peering guide

* Add Azure NVA example to Azure peering guide

* Additional revisions from review feedback

* Backticks to single
@jasonpilz
Merge branch 'main' into jasonpilz/guides-nav
7aca0a8
@jasonpilz
Merge branch 'main' into jasonpilz/guides-nav
8eac97b
codergs
codergs approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@codergs codergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hcp vault pages looks good to me.

crhino
crhino approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@crhino crhino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasonpilz jasonpilz requested review from a team and removed request for himran92 and aslamovamir January 18, 2024 17:18
@jasonpilz jasonpilz merged commit 4f9cc28 into main Jan 18, 2024
6 checks passed
@jasonpilz jasonpilz deleted the jasonpilz/guides-nav branch January 18, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierluc-codes pierluc-codes pierluc-codes approved these changes

@crhino crhino crhino approved these changes

@codergs codergs codergs approved these changes

@sylviamoss sylviamoss sylviamoss approved these changes

@aidan-mundy aidan-mundy aidan-mundy approved these changes

@mercedesbh mercedesbh mercedesbh approved these changes

@manish-hashicorp manish-hashicorp manish-hashicorp approved these changes

@dmalch-hashicorp dmalch-hashicorp dmalch-hashicorp approved these changes

@delores-hashicorp delores-hashicorp delores-hashicorp approved these changes

Assignees

@jasonpilz jasonpilz

Labels
pr/no-changelog Auto-pinning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@jasonpilz @pierluc-codes @crhino @codergs @sylviamoss @aidan-mundy @mercedesbh @manish-hashicorp @dmalch-hashicorp @delores-hashicorp