Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HCE-793: Add Project ID to Vault Cluster #474

Merged
merged 3 commits into from
Mar 13, 2023
Merged

HCE-793: Add Project ID to Vault Cluster #474

merged 3 commits into from
Mar 13, 2023

Conversation

itsjaspermilan
Copy link
Contributor

🛠️ Description

Add project_id to Vault Cluster resource.

@itsjaspermilan itsjaspermilan requested review from a team, bosouza and andrey-donelli and removed request for a team March 3, 2023 20:36
bcmdarroch
bcmdarroch reviewed Mar 3, 2023
View reviewed changes
Copy link
Contributor

@bcmdarroch bcmdarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to update https://github.com/hashicorp/terraform-provider-hcp/blob/main/internal/provider/resource_vault_cluster_admin_token.go

@bcmdarroch bcmdarroch force-pushed the hce-339-feat-multi-project branch from c33f375 to f8c0d9e Compare March 8, 2023 22:15
@bcmdarroch bcmdarroch requested review from a team as code owners March 8, 2023 22:15
@bcmdarroch bcmdarroch force-pushed the hce-793-add-project-id-to-vault-cluster branch from fb24262 to 47f60ea Compare March 8, 2023 22:47
@bcmdarroch bcmdarroch force-pushed the hce-793-add-project-id-to-vault-cluster branch from 47f60ea to 597f0f9 Compare March 8, 2023 22:55
@itsjaspermilan itsjaspermilan merged commit cf23962 into hce-339-feat-multi-project Mar 13, 2023
@itsjaspermilan itsjaspermilan deleted the hce-793-add-project-id-to-vault-cluster branch March 13, 2023 21:23
delores-hashicorp pushed a commit that referenced this pull request May 12, 2023
@itsjaspermilan @delores-hashicorp
HCE-793: Add Project ID to Vault Cluster (#474)
e8f1723 
* add project_id

* typo

* missing resource
delores-hashicorp pushed a commit that referenced this pull request May 12, 2023
@itsjaspermilan @delores-hashicorp
HCE-793: Add Project ID to Vault Cluster (#474)
fdc2a92 
* add project_id

* typo

* missing resource
dmalch-hashicorp pushed a commit that referenced this pull request May 23, 2023
@itsjaspermilan @dmalch-hashicorp
HCE-793: Add Project ID to Vault Cluster (#474)
e54f891 
* add project_id

* typo

* missing resource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcmdarroch bcmdarroch bcmdarroch left review comments

@aoripov aoripov aoripov approved these changes

@bosouza bosouza Awaiting requested review from bosouza

@andrey-donelli andrey-donelli Awaiting requested review from andrey-donelli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itsjaspermilan @aoripov @bcmdarroch