Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for GitLab integration #1189

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Add support for GitLab integration #1189

merged 1 commit into from
Jan 29, 2025

Conversation

rodrigo-hcp
Copy link
Contributor

@rodrigo-hcp rodrigo-hcp commented Jan 23, 2025 •
edited
Loading

This PR adds support for creating GitLab integrations via the HCP provider.

🛠️ Description

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccVaultSecretsResourceIntegrationGitLab'

...

@rodrigo-hcp rodrigo-hcp self-assigned this Jan 23, 2025
@rodrigo-hcp rodrigo-hcp requested review from a team as code owners January 23, 2025 22:34
@hashicorp-cla-app HashiCorp CLA App
Copy link

hashicorp-cla-app bot commented Jan 23, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rodrigo-hcp rodrigo-hcp force-pushed the hvs-gitlab-integration branch 5 times, most recently from cb4854b to 7df5d95 Compare January 28, 2025 21:20
@rodrigo-hcp rodrigo-hcp force-pushed the hvs-gitlab-integration branch from 7df5d95 to b4aa4ea Compare January 28, 2025 21:29
maxcoulombe
maxcoulombe approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@maxcoulombe maxcoulombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@rodrigo-hcp rodrigo-hcp merged commit 63727a5 into main Jan 29, 2025
7 checks passed
@rodrigo-hcp rodrigo-hcp deleted the hvs-gitlab-integration branch January 29, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huikang huikang huikang approved these changes

@divyapola5 divyapola5 divyapola5 approved these changes

@maxcoulombe maxcoulombe maxcoulombe approved these changes

Assignees

@rodrigo-hcp rodrigo-hcp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rodrigo-hcp @huikang @divyapola5 @maxcoulombe