Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamCity: Address edge case of google-beta package containing a hyphen #15449

Conversation

modular-magician
Copy link
Collaborator

Quick fix hot on the heels of GoogleCloudPlatform/magic-modules#8560

I forgot that the Beta provider would have a package with a hyphen in the name, and we need to protect against it.

    fun uniqueID() : String {
        // Replacing chars can be necessary, due to limitations on IDs
        // "ID should start with a latin letter and contain only latin letters, digits and underscores (at most 225 characters)." 
        var pv = this.providerName.replace("-", "").toUpperCase()
-        var pkg = this.packageName.toUpperCase()
+        var pkg = this.packageName.replace("-", "").toUpperCase()

        return "%s_PACKAGE_%s".format(pv, pkg)
    }

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#8594

…orp#8594)

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit aabd7b3 into hashicorp:main Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Sep 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2023
@modular-magician modular-magician deleted the downstream-pr-d71226af6bc3e293de5e422be92ea88e5e6257d0 branch November 17, 2024 02:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant