Add missing fields to compute resources [KMS and disks] #9328
+2,227
−58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes hashicorp/terraform-provider-google#18050
Hi this is a PR to fix feature gap between the API and the provider on disks and encryption. I'll look for any tickets that this fixes and update them later.
Tested this for basic breaking changes (created an instance on upstream provider and did a terraform apply on the custom provider) - no changes in configuration shown
On some of these fields i wasn't able to add a
ConflictsWith
param. LMK if the API errors are sufficient in these cases or do we want this to throw an error on terraform's sideAlso for the
guest_os_features
field i've made it so that it is computed but it will show null until the user sets it in his config. This field changes based on the source used for the disk and is ForceNew, so i think that this it's a safer behavior to have it null until the user specifficaly sets it in his config.Fields added:
google_compute_instance
google_compute_image
google_compute_snapshot
google_compute_instance_template
google_compute_region_instance_template
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Derived from GoogleCloudPlatform/magic-modules#12672