Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add certificate_map to compute_target_https_proxy #4061

Closed
wants to merge 2 commits into from

Conversation

MoinTom
Copy link

@MoinTom MoinTom commented Feb 17, 2022

related to issue hashicorp/terraform-provider-google#11037

Add certificate_map option to compute_target_https_proxy in order to support new certificate-manager (with wildcard support).

Relevant Documentation for this new field/feature:
How To Cert Manager
setCertificateMap

@MoinTom
Copy link
Author

MoinTom commented Feb 17, 2022

I am not sure about some of my changes. Specially the new LocationFieldValue type, which was sort of required for the (new?) path format that is used by certificateMaps resources.

@rileykarson
Copy link
Collaborator

@megan07: I suspect the reviewer lottery only applies to "Ready for Review" PRs and not drafts, this doesn't seem to have had one assigned!

@MoinTom MoinTom marked this pull request as ready for review April 19, 2022 13:51
@github-actions github-actions bot requested a review from shuyama1 April 19, 2022 13:52
@shuyama1
Copy link
Collaborator

@MoinTom Thanks for making the changes! Would you mind making this change against https://github.com/GoogleCloudPlatform/magic-modules following the instruction here

@MoinTom
Copy link
Author

MoinTom commented Apr 28, 2022

@shuyama1 oh, totally overlooked the fact that those files are generated.

I can create a short PR with the added certificate_map field, however it seems like it's not possible to add certificate_map without first adding a CertificateMap resource. At least when i tried using the (correct) ResourceRef-Type. It works with the simpler String-Type, that doesn't offer link validation and self-discovery (name -> selfLink), but it should at least be usable for the time being.

However i noticed that someone already implemented the CertificateManager, but it got removed: GoogleCloudPlatform/magic-modules#4968
Maybe resurrecting this would be the smarter first move here.

@MoinTom
Copy link
Author

MoinTom commented Apr 28, 2022

Here my draft for adding certificate_map as String-Type: GoogleCloudPlatform/magic-modules#5991

@MoinTom
Copy link
Author

MoinTom commented Apr 29, 2022

I will close this PR since changes are required upstream.

@MoinTom MoinTom closed this Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants