Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Compact Placement feature for GKE nodes #4043

Conversation

modular-magician
Copy link
Collaborator

Compact Placement is a GKE node pool feature that allows to locate nodes in a close physical proximity to each other and achieve lower communication within the node pool. Compact Placement is currently in preview (beta).

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: Add support for GKE Compact Placement

Note I was able to test my code end-to-end with terraform, but I wasn't able to run the acceptance tests. The acceptance tests seem to be always using the GA provider.

Derived from GoogleCloudPlatform/magic-modules#5656

* Add support for the Compact Placement node pool feature

* Update GKE API dependency

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 3a69034 into hashicorp:master Feb 10, 2022
@modular-magician modular-magician deleted the downstream-pr-1e954e37ad061f8dc4d7fa855efc8ad672095a92 branch November 16, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant