Fixed binary log doc (#5963) (#4245)

Signed-off-by: Modular Magician <magic-modules@google.com>
hashicorp · Apr 21, 2022 · fc91610 · fc91610
1 parent 74b2ad5
commit fc91610
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 12 deletions.
diff --git a/.changelog/5963.txt b/.changelog/5963.txt
@@ -0,0 +1,2 @@
+```release-note:none
+```
diff --git a/google-beta/resource_sql_database_instance.go b/google-beta/resource_sql_database_instance.go
@@ -160,12 +160,11 @@ func resourceSqlDatabaseInstance() *schema.Resource {
 							Default:      "ZONAL",
 							ValidateFunc: validation.StringInSlice([]string{"REGIONAL", "ZONAL"}, false),
 							Description: `The availability type of the Cloud SQL instance, high availability
-(REGIONAL) or single zone (ZONAL). For MySQL and SQL Server instances, ensure that
-settings.backup_configuration.enabled and
-settings.backup_configuration.binary_log_enabled are both set to true.
-For Postgres instances, ensure that settings.backup_configuration.enabled
-and settings.backup_configuration.point_in_time_recovery_enabled
-are both set to true.`,
+(REGIONAL) or single zone (ZONAL). For all instances, ensure that
+settings.backup_configuration.enabled is set to true.
+For MySQL instances, ensure that settings.backup_configuration.binary_log_enabled is set to true.
+For Postgres instances, ensure that settings.backup_configuration.point_in_time_recovery_enabled
+is set to true.`,
 						},
 						"backup_configuration": {
 							Type:     schema.TypeList,
@@ -178,7 +177,7 @@ are both set to true.`,
 										Type:         schema.TypeBool,
 										Optional:     true,
 										AtLeastOneOf: backupConfigurationKeys,
-										Description:  `True if binary logging is enabled. If settings.backup_configuration.enabled is false, this must be as well. Cannot be used with Postgres.`,
+										Description:  `True if binary logging is enabled. If settings.backup_configuration.enabled is false, this must be as well. Can only be used with MySQL.`,
 									},
 									"enabled": {
 										Type:         schema.TypeBool,

diff --git a/website/docs/r/sql_database_instance.html.markdown b/website/docs/r/sql_database_instance.html.markdown
@@ -230,10 +230,11 @@ The `settings` block supports:
     active. Can be either `ALWAYS`, `NEVER` or `ON_DEMAND`.
 
 * `availability_type` - (Optional, Default: `ZONAL`) The availability type of the Cloud SQL
-  instance, high availability (`REGIONAL`) or single zone (`ZONAL`).' For MySQL and SQL Server instances,
-  ensure that `settings.backup_configuration.enabled` and `settings.backup_configuration.binary_log_enabled`
-  are both set to `true`. For Postgres instances, ensure that `settings.backup_configuration.enabled`
-  and `settings.backup_configuration.point_in_time_recovery_enabled` are both set to `true`.
+  instance, high availability (`REGIONAL`) or single zone (`ZONAL`).' For all instances, ensure that
+  `settings.backup_configuration.enabled` is set to `true`.
+  For MySQL instances, ensure that `settings.backup_configuration.binary_log_enabled` is set to `true`.
+  For Postgres instances, ensure that `settings.backup_configuration.point_in_time_recovery_enabled`
+  is set to `true`.
 
 * `collation` - (Optional) The name of server instance collation.
 
@@ -256,7 +257,7 @@ The optional `settings.database_flags` sublist supports:
 The optional `settings.backup_configuration` subblock supports:
 
 * `binary_log_enabled` - (Optional) True if binary logging is enabled.
-    Cannot be used with Postgres.
+    Can only be used with MySQL.
 
 * `enabled` - (Optional) True if backup configuration is enabled.