Mark advanced machine features not Computed (#5313) (#3786)

Signed-off-by: Modular Magician <magic-modules@google.com>
hashicorp · Oct 27, 2021 · ef8aea8 · ef8aea8
1 parent 3c791bd
commit ef8aea8
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/.changelog/5313.txt b/.changelog/5313.txt
@@ -0,0 +1,3 @@
+```release-note:breaking-change
+compute: changed `advanced_machine_features` on `google_compute_instance_template` to track changes when the block is undefined in a user's config
+```
diff --git a/google-beta/resource_compute_instance_template.go b/google-beta/resource_compute_instance_template.go
@@ -628,7 +628,6 @@ func resourceComputeInstanceTemplate() *schema.Resource {
 				Type:        schema.TypeList,
 				MaxItems:    1,
 				Optional:    true,
-				Computed:    true,
 				ForceNew:    true,
 				Description: `Controls for advanced machine-related behavior features.`,
 				Elem: &schema.Resource{

diff --git a/google-beta/resource_gke_hub_feature_membership_test.go b/google-beta/resource_gke_hub_feature_membership_test.go
@@ -5,7 +5,7 @@ import (
 	"fmt"
 	"testing"
 
-	dcl "github.com/GoogleCloudPlatform/declarative-resource-client-library/dcl"
+	"github.com/GoogleCloudPlatform/declarative-resource-client-library/dcl"
 	gkehub "github.com/GoogleCloudPlatform/declarative-resource-client-library/services/google/gkehub/beta"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"

diff --git a/website/docs/guides/version_4_upgrade.html.markdown b/website/docs/guides/version_4_upgrade.html.markdown
@@ -353,6 +353,12 @@ This field was incorrectly included in the GA `google` provider in past releases
 In order to continue to use the feature, add `provider = google-beta` to your
 resource definition.
 
+### `advanced_machine_features` will track changes when unspecified in a config
+
+In `3.X`, `advanced_machine_features` wouldn't cause a diff if it was undefined in
+config but was set on the instance template itself. With 4.0.0 Terraform will now
+track changes on the block when it is not specified in a user's config.
+
 ## Resource: `google_compute_url_map`
 
 ### At least one of `default_route_action.0.fault_injection_policy.0.delay.0.fixed_delay` or `default_route_action.0.fault_injection_policy.0.delay.0.percentage` is required