feat: Also log command stderr at TRACE level

[pdecat]

Resolves #67

[gorge511]

Hi, @pdecat @austinvalle is there any plan to finish this? I spent a whole day investigating why my external data resource is not working on our CI/CD and this feature would help me a lot. Thanks

[pdecat]

Hi @gorge511, from my point of view, this is finished and ready to merge (I'm just a contributor here).

[austinvalle]

LGTM. Thanks for the contribution @pdecat and apologies for the delay on reviewing this. I'll add a small note changelog to this and merge/release it next week 👍🏻

Our CI is bugged right now for PRs from forks, so the tests didn't run, but I pulled the PR down and it all looks good.

 $ make testacc                                                  
TF_ACC=1 go test -v -cover -timeout 120m ./...
?       github.com/terraform-providers/terraform-provider-external      [no test files]
?       github.com/terraform-providers/terraform-provider-external/internal/provider/test-programs/tf-acc-external-data-source       [no test files]
=== RUN   TestDataSource_basic
--- PASS: TestDataSource_basic (0.68s)
=== RUN   TestDataSource_error
--- PASS: TestDataSource_error (0.26s)
=== RUN   TestDataSource_Program_OnlyEmptyString
--- PASS: TestDataSource_Program_OnlyEmptyString (0.17s)
=== RUN   TestDataSource_Program_PathAndEmptyString
--- PASS: TestDataSource_Program_PathAndEmptyString (0.63s)
=== RUN   TestDataSource_Program_EmptyStringAndNullValues
--- PASS: TestDataSource_Program_EmptyStringAndNullValues (0.17s)
=== RUN   TestDataSource_Query_EmptyElementValue
--- PASS: TestDataSource_Query_EmptyElementValue (0.61s)
=== RUN   TestDataSource_Query_NullElementValue
--- PASS: TestDataSource_Query_NullElementValue (0.55s)
=== RUN   TestDataSource_CurrentDir
--- PASS: TestDataSource_CurrentDir (0.65s)
=== RUN   TestDataSource_upgrade
--- PASS: TestDataSource_upgrade (3.38s)
=== RUN   TestDataSource_20MinuteTimeout
    data_source_test.go:414: Skipping this test since the TF_ACC_EXTERNAL_TIMEOUT_TEST environment variable is not set to any value. This test requires 20 minutes to run, so it is disabled by default.
--- SKIP: TestDataSource_20MinuteTimeout (0.00s)
PASS
coverage: 84.0% of statements
ok      github.com/terraform-providers/terraform-provider-external/internal/provider    7.973s  coverage: 84.0% of statements

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.