azurerm_policy_set_definition - parameters is ForceNew if there are less or differing parameters between runs

[pemcne]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This brings the functionality of #26083 to policy_set_definition as well.

Since policy_set_definition and policy_definition share the same parameter logic, I consolidated this diff logic into the policy.go and both resources now call the same CustomizeDiffShim function. I added additional functionality to the original policy_definition logic by also forcing new if the parameter lengths are the same but the parameters don't match (catching use cases of renames or +1/-1 parameters) since the Azure API will reject that in the current logic.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Tested this manually and with acceptance testing (copying the tests from the policy_definition).

make acctests SERVICE=policy TESTARGS='-run=TestAccAzureRMPolicySetDefinition_removeParameter' TESTTIMEOUT=15m
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/policy -run=TestAccAzureRMPolicySetDefinition_removeParameter -timeout 15m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMPolicySetDefinition_removeParameter
=== PAUSE TestAccAzureRMPolicySetDefinition_removeParameter
=== CONT  TestAccAzureRMPolicySetDefinition_removeParameter
--- PASS: TestAccAzureRMPolicySetDefinition_removeParameter (176.64s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• policy_set_definition - parameters is ForceNew if there are less or differing parameters between runs [azurerm_policy_set_definition - parameters is ForceNew if there are less or differing parameters between runs #28769]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

No related issues found.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.