azurerm_data_factory_pipeline - migrate to hashicorp/go-azure-sdk

[stephybun]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

• Moved the expand/flatten function for variables and parameters into the pipeline resource since that is the only place they're used
• Added a complete test with all resource properties specified and multiple activity types in the activities_json
• Update the update test to update all updateable properties as well as update back to the basic config
• Removed the custom serialize and deserialize functions for the activities_json which were replaced by the Unmarshaler for discriminated types in the go-azure-sdk
• Removed the azuresdkhacks folder and contents since this has been replaced by go-azure-sdk

Note: I opted to not also split the Create and Update methods here, since this is already quite a big change to the resource

Testing

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• dependencies: azurerm_data_factory_pipelines update to use hashicorp/go-azure-sdk [GH-00000]
• azurerm_data_factory_pipelines - fix issue where a web activity with a header in activities_json could not be unmarshaled [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #24998

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[catriona-m]

LGTM!

[catriona-m]

could pointer.From be used here?

[stephybun]

It can! Thanks for the spot