Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resources: azurerm_mssql_job and azurerm_mssql_job_schedule #28456

Merged
merged 7 commits into from
Jan 15, 2025
Merged

New resources: azurerm_mssql_job and azurerm_mssql_job_schedule #28456

merged 7 commits into from
Jan 15, 2025

Conversation

sreallymatt
Copy link
Collaborator

@sreallymatt sreallymatt commented Jan 9, 2025 •
edited
Loading

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Added new resources azurerm_mssql_job and azurerm_mssql_job_schedule

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@sreallymatt sreallymatt requested a review from a team as a code owner January 9, 2025 00:39
@sreallymatt
Copy link
Collaborator Author

image

stephybun
stephybun requested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sreallymatt! This is off to a good start, would you mind taking a look through the comments I left in-line? Once those are resolved this should be good to go!

internal/services/mssql/mssql_job_resource.go Outdated Show resolved Hide resolved
internal/services/mssql/mssql_job_resource.go Outdated Show resolved Hide resolved
internal/services/mssql/mssql_job_resource.go Outdated Show resolved Hide resolved
internal/services/mssql/mssql_job_resource.go Outdated Show resolved Hide resolved
internal/services/mssql/mssql_job_resource.go Outdated Show resolved Hide resolved
internal/services/mssql/mssql_job_schedule_resource.go Show resolved Hide resolved
internal/services/mssql/mssql_job_schedule_resource.go Show resolved Hide resolved
internal/services/mssql/mssql_job_schedule_resource.go Show resolved Hide resolved
website/docs/r/mssql_job.html.markdown Show resolved Hide resolved
website/docs/r/mssql_job.html.markdown Outdated Show resolved Hide resolved
@sreallymatt @stephybun
Apply suggestions from code review
ff5dbcc 
Co-authored-by: stephybun <steph@hashicorp.com>
@sreallymatt sreallymatt mentioned this pull request Jan 14, 2025
Merged
9 tasks
stephybun
stephybun approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sreallymatt! Provided tests are still passing after latest changes LGTM 💯

@sreallymatt sreallymatt merged commit 0fa6a35 into main Jan 15, 2025
34 checks passed
@sreallymatt sreallymatt deleted the mp/mssql-jobs branch January 15, 2025 14:41
@github-actions github-actions bot added this to the v4.16.0 milestone Jan 15, 2025
sreallymatt added a commit that referenced this pull request Jan 15, 2025
@sreallymatt
Update CHANGELOG for #28456
96013ab
jackofallops added a commit that referenced this pull request Jan 16, 2025
@stephybun @jackofallops
@catriona-m @sreallymatt @mbfrahry
CHANGELOG.md release v4.16.0 (#28488)
f54480d 
* update for #27680

* Update CHANGELOG.md for #28465

* Update CHANGELOG.md #27932

* Update CHANGELOG.md for #28505

* Update CHANGELOG.md for #28474

* Update CHANGELOG.md #28516

* Update CHANGELOG for #28456

* Update CHANGELOG.md for #28472

* Update CHANGELOG.md #28307

* Update CHANGELOG.md for #27859

* Update for #28519

* Update for #27791 #27528

* Update CHANGELOG.md for #28527

* update changelog links and generate provider schema

---------

Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>
Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com>
Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
Co-authored-by: Matthew Frahry <mbfrahry@gmail.com>
Co-authored-by: jackofallops <ste@hashicorp.com>
NotTheEvilOne pushed a commit to b1-systems/terraform-provider-azurerm that referenced this pull request Jan 20, 2025
@sreallymatt @stephybun @NotTheEvilOne
New resources: azurerm_mssql_job and azurerm_mssql_job_schedule (h…
77da2eb 
…ashicorp#28456)

* New resources: azurerm_mssql_job and azurerm_mssql_job_schedule

* Update timeouts

* Fix lint

* Update struct name to follow convention

* Apply suggestions from code review

Co-authored-by: stephybun <steph@hashicorp.com>

* Update internal/services/mssql/mssql_job_schedule_resource.go

Co-authored-by: stephybun <steph@hashicorp.com>

* Update based on comments

---------

Co-authored-by: stephybun <steph@hashicorp.com>
NotTheEvilOne pushed a commit to b1-systems/terraform-provider-azurerm that referenced this pull request Jan 20, 2025
@stephybun @jackofallops
@catriona-m @sreallymatt @mbfrahry @NotTheEvilOne
CHANGELOG.md release v4.16.0 (hashicorp#28488)
9a8d11b 
* update for hashicorp#27680

* Update CHANGELOG.md for hashicorp#28465

* Update CHANGELOG.md hashicorp#27932

* Update CHANGELOG.md for hashicorp#28505

* Update CHANGELOG.md for hashicorp#28474

* Update CHANGELOG.md hashicorp#28516

* Update CHANGELOG for hashicorp#28456

* Update CHANGELOG.md for hashicorp#28472

* Update CHANGELOG.md hashicorp#28307

* Update CHANGELOG.md for hashicorp#27859

* Update for hashicorp#28519

* Update for hashicorp#27791 hashicorp#27528

* Update CHANGELOG.md for hashicorp#28527

* update changelog links and generate provider schema

---------

Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>
Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com>
Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
Co-authored-by: Matthew Frahry <mbfrahry@gmail.com>
Co-authored-by: jackofallops <ste@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees

@stephybun stephybun

Labels
dependencies documentation new-resource service/mssql Microsoft SQL Server size/XL
Projects
None yet
Milestone
v4.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sreallymatt @stephybun @rcskosir