azurerm_kusto_cluster - Fixes virtual_network_configuration block

[liuwuliuyun]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Affected Resource: azurerm_kusto_cluster

Background: #24733

The MS Kusto service team and the customer success team have informed me that deleting the virtual_network_configuration block in azurerm_kusto_cluster will trigger forceNew and delete all existing data in the Kusto cluster, which is not the intended outcome. I have been able to reproduce this issue on my local machine with assistance from the Kusto team. The expected behavior is that removing the virtual_network_configuration block should set it to the Disabled state.

Changes

• Remove all forceNew labels from the subproperties of the virtual_network_configuration block in the azurerm_kusto_cluster resource.
• Include a custom diff function to prevent any changes to the subproperties of the virtual_network_configuration block, except for the creation and removal of the block itself.
• I have confirmed with the service team that setting the virtual_network_configuration block to the Disabled state will not change public_network_access_enabled to false, so I have removed this description from the document.
• I have also confirmed through local tests that the State can be changed from Disabled to Enabled again, so I have updated the documentation accordingly.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_kusto_cluster - Fixes block virtual_network_configuration [GH-28249]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Fixes #27660

[wyattfry]

I'm sorry, I had a realization that making the change I recommended (removing the empty string checks) will allow newSubnetId to be an empty string if oldSubnetId is not, and vice-versa. However, the commonids.ValidateSubnetID function will not allow empty strings, so I think we are ok.

[cosh]

Good. So can you merge it?

[liuwuliuyun]

Hi @wyattfry, I have reset this branch to the original commit. Let me know if you think there are still changes needed, and I am happy to assist with merging this PR.