Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.ci/semgrep: add avoid-SingleNestedBlock rule #41610

Merged
merged 1 commit into from
Mar 3, 2025
Merged

.ci/semgrep: add avoid-SingleNestedBlock rule #41610

merged 1 commit into from
Mar 3, 2025

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Feb 28, 2025

Description

This rule will check for any usage of schema.SingleNestedBlock within the internal/service subfolder. Pre-existing instances of SingleNestedBlocks have been annotated with nosemgrep trailing comments. These will be migrated in the future.

Relations

Relates #35813

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/elbv2 Issues and PRs that pertain to the elbv2 service. linter Pertains to changes to or issues with the various linters. service/resiliencehub Issues and PRs that pertain to the resiliencehub service. service/rekognition Issues and PRs that pertain to the rekognition service. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. service/verifiedpermissions Issues and PRs that pertain to the verifiedpermissions service. service/bedrock Issues and PRs that pertain to the bedrock service. service/paymentcryptography Issues and PRs that pertain to the paymentcryptography service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Feb 28, 2025
@jar-b
.ci/semgrep: add avoid-SingleNestedBlock rule
97965e7 
This rule will check for any usage of `schema.SingleNestedBlock` within the `internal/service` subfolder. Pre-existing instances of `SingleNestedBlock`s have been annotated with `nosemgrep` trailing comments. These will be migrated in the future.
@jar-b jar-b force-pushed the td-single-nested-block branch from 8d8665f to 97965e7 Compare February 28, 2025 18:38
@jar-b jar-b marked this pull request as ready for review February 28, 2025 19:01
@jar-b jar-b requested a review from a team as a code owner February 28, 2025 19:01
ewbankkit
ewbankkit approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit 2381cdc into main Mar 3, 2025
40 checks passed
@jar-b jar-b deleted the td-single-nested-block branch March 3, 2025 15:49
@github-actions github-actions bot added this to the v5.90.0 milestone Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
linter Pertains to changes to or issues with the various linters. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/bedrock Issues and PRs that pertain to the bedrock service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. service/paymentcryptography Issues and PRs that pertain to the paymentcryptography service. service/rekognition Issues and PRs that pertain to the rekognition service. service/resiliencehub Issues and PRs that pertain to the resiliencehub service. service/verifiedpermissions Issues and PRs that pertain to the verifiedpermissions service.
Projects
None yet
Milestone
v5.90.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jar-b @ewbankkit