-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
b/aws_ecs_service: fix VPC Lattice configuration removal #41594
Merged
ewbankkit
merged 7 commits into
hashicorp:main
from
marcinbelczewski:b/ecs-service-lattice-config-removal
Feb 28, 2025
Merged
b/aws_ecs_service: fix VPC Lattice configuration removal #41594
ewbankkit
merged 7 commits into
hashicorp:main
from
marcinbelczewski:b/ecs-service-lattice-config-removal
Feb 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
2ddf119
to
1d52d18
Compare
r/aws_vpclattice_target_group: allow for submitting delete request while targets are still draining
1d52d18
to
ae3e1ea
Compare
ewbankkit
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccECSService_LatticeConfigurations\|TestAccECSService_basic' PKG=ecs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run=TestAccECSService_LatticeConfigurations\|TestAccECSService_basic -timeout 360m -vet=off
2025/02/28 10:51:28 Initializing Terraform AWS Provider...
=== RUN TestAccECSService_basic
=== PAUSE TestAccECSService_basic
=== RUN TestAccECSService_basicImport
=== PAUSE TestAccECSService_basicImport
=== RUN TestAccECSService_LatticeConfigurations
=== PAUSE TestAccECSService_LatticeConfigurations
=== CONT TestAccECSService_basic
=== CONT TestAccECSService_LatticeConfigurations
=== CONT TestAccECSService_basicImport
--- PASS: TestAccECSService_basic (69.48s)
--- PASS: TestAccECSService_basicImport (195.62s)
--- PASS: TestAccECSService_LatticeConfigurations (565.70s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 571.236s
% make testacc TESTARGS='-run=TestAccVPCLatticeTargetGroup_' PKG=vpclattice ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/vpclattice/... -v -count 1 -parallel 3 -run=TestAccVPCLatticeTargetGroup_ -timeout 360m -vet=off
2025/02/28 11:32:31 Initializing Terraform AWS Provider...
=== RUN TestAccVPCLatticeTargetGroup_basic
=== PAUSE TestAccVPCLatticeTargetGroup_basic
=== RUN TestAccVPCLatticeTargetGroup_disappears
=== PAUSE TestAccVPCLatticeTargetGroup_disappears
=== RUN TestAccVPCLatticeTargetGroup_tags
=== PAUSE TestAccVPCLatticeTargetGroup_tags
=== RUN TestAccVPCLatticeTargetGroup_lambda
=== PAUSE TestAccVPCLatticeTargetGroup_lambda
=== RUN TestAccVPCLatticeTargetGroup_lambdaEventStructureVersion
=== PAUSE TestAccVPCLatticeTargetGroup_lambdaEventStructureVersion
=== RUN TestAccVPCLatticeTargetGroup_ip
=== PAUSE TestAccVPCLatticeTargetGroup_ip
=== RUN TestAccVPCLatticeTargetGroup_alb
=== PAUSE TestAccVPCLatticeTargetGroup_alb
=== CONT TestAccVPCLatticeTargetGroup_basic
=== CONT TestAccVPCLatticeTargetGroup_lambdaEventStructureVersion
=== CONT TestAccVPCLatticeTargetGroup_alb
--- PASS: TestAccVPCLatticeTargetGroup_lambdaEventStructureVersion (17.21s)
=== CONT TestAccVPCLatticeTargetGroup_tags
--- PASS: TestAccVPCLatticeTargetGroup_tags (32.40s)
=== CONT TestAccVPCLatticeTargetGroup_ip
--- PASS: TestAccVPCLatticeTargetGroup_basic (71.47s)
=== CONT TestAccVPCLatticeTargetGroup_lambda
--- PASS: TestAccVPCLatticeTargetGroup_lambda (17.60s)
=== CONT TestAccVPCLatticeTargetGroup_disappears
--- PASS: TestAccVPCLatticeTargetGroup_alb (87.80s)
--- PASS: TestAccVPCLatticeTargetGroup_ip (80.83s)
--- PASS: TestAccVPCLatticeTargetGroup_disappears (63.23s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice 153.457s
jar-b
approved these changes
Feb 28, 2025
@marcinbelczewski Thanks for the contribution 🎉 👏. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Addresses a defect in current functionality.
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
service/ecs
Issues and PRs that pertain to the ecs service.
service/vpclattice
Issues and PRs that pertain to the vpclattice service.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
aws_ecs_service
. ECS API requires empty array to be passed in UpdateService request for that and currentlynull
is being passed.aws_vpclattice_target_group
configuration so that delete request can be sent while the targets are still draining (that will happen for example during acceptance tests ofaws_ecs_service
)Relations
Closes #41600.
Closes #41601.
References
Output from Acceptance Testing