Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: aws_timestreamquery_scheduled_query #41145

Merged
merged 26 commits into from
Jan 30, 2025

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jan 29, 2025

Description

Amazon Timestream for LiveAnalytics offers a scheduled query feature that helps businesses efficiently process and store aggregated data for real-time analytics. This fully managed, serverless solution automatically runs predefined queries to compute aggregates, rollups, and other summaries, storing the results in a separate table. By doing so, scheduled queries enhance performance and reduce costs, making real-time analytics more accessible for dashboards, reports, and other business applications.

Instead of querying large source tables, users can query these smaller, preprocessed tables, significantly improving speed and reducing storage costs. The feature integrates seamlessly with existing tools like SQL, Grafana, Amazon Kinesis, AWS IoT Core, and Telegraf. Additionally, data retention for aggregated tables is independent of source tables, allowing businesses to store key insights longer at a lower cost while keeping the original data only as long as necessary. This makes real-time analytics faster, more cost-effective, and scalable for a wide range of use cases.

Relations

Closes #22507

References

Output from Acceptance Testing

% make t T=TestAccTimestreamQueryScheduledQuery_ K=timestreamquery
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/timestreamquery/... -v -count 1 -parallel 20 -run='TestAccTimestreamQueryScheduledQuery_'  -timeout 360m -vet=off
2025/01/29 17:31:30 Initializing Terraform AWS Provider...
=== RUN   TestAccTimestreamQueryScheduledQuery_basic
=== PAUSE TestAccTimestreamQueryScheduledQuery_basic
=== RUN   TestAccTimestreamQueryScheduledQuery_disappears
=== PAUSE TestAccTimestreamQueryScheduledQuery_disappears
=== CONT  TestAccTimestreamQueryScheduledQuery_basic
=== CONT  TestAccTimestreamQueryScheduledQuery_disappears
--- PASS: TestAccTimestreamQueryScheduledQuery_disappears (110.71s)
--- PASS: TestAccTimestreamQueryScheduledQuery_basic (112.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/timestreamquery	117.395s

@YakDriver YakDriver requested a review from a team as a code owner January 29, 2025 22:23
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. tags Pertains to resource tagging. generators Relates to code generators. service/timestreamquery Issues and PRs that pertain to the timestreamquery service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Jan 29, 2025
@YakDriver
Copy link
Member Author

New and Improved! ⭐ Contains 0 SingleNestedBlocks!

% make t T=TestAccTimestreamQueryScheduledQuery_ K=timestreamquery 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/timestreamquery/... -v -count 1 -parallel 20 -run='TestAccTimestreamQueryScheduledQuery_'  -timeout 360m -vet=off
2025/01/29 20:22:37 Initializing Terraform AWS Provider...
=== RUN   TestAccTimestreamQueryScheduledQuery_basic
=== PAUSE TestAccTimestreamQueryScheduledQuery_basic
=== RUN   TestAccTimestreamQueryScheduledQuery_disappears
=== PAUSE TestAccTimestreamQueryScheduledQuery_disappears
=== CONT  TestAccTimestreamQueryScheduledQuery_basic
=== CONT  TestAccTimestreamQueryScheduledQuery_disappears
--- PASS: TestAccTimestreamQueryScheduledQuery_disappears (107.43s)
--- PASS: TestAccTimestreamQueryScheduledQuery_basic (109.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/timestreamquery	113.214s

Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make t T=TestAccTimestreamQueryScheduledQuery_ K=timestreamquery

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/timestreamquery/... -v -count 1 -parallel 20 -run='TestAccTimestreamQueryScheduledQuery_'  -timeout 360m -vet=off
2025/01/29 19:36:59 Initializing Terraform AWS Provider...
--- PASS: TestAccTimestreamQueryScheduledQuery_disappears (100.73s)
--- PASS: TestAccTimestreamQueryScheduledQuery_basic (102.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/timestreamquery	109.381s

@YakDriver YakDriver merged commit 8604add into main Jan 30, 2025
44 checks passed
@YakDriver YakDriver deleted the f-new-resource-timestream-schedule-query branch January 30, 2025 03:29
@github-actions github-actions bot added this to the v5.85.0 milestone Jan 30, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Jan 30, 2025
Copy link

github-actions bot commented Feb 3, 2025

This functionality has been released in v5.85.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/timestreamquery Issues and PRs that pertain to the timestreamquery service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Resource: Timestream Scheduled Query
2 participants