Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/ssoadmin_permission_set_inline_policy: new resource #17003

Closed
wants to merge 2 commits into from
Closed

r/ssoadmin_permission_set_inline_policy: new resource #17003

wants to merge 2 commits into from

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 7, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Preceded by #15808
Relates #15108
Relates #15540

Release note for CHANGELOG:

r/ssoadmin_permission_set_inline_policy: new resource

Output from acceptance testing:

--- PASS: TestAccAWSSSOAdminPermissionSetInlinePolicy_disappears (21.74s)
--- PASS: TestAccAWSSSOAdminPermissionSetInlinePolicy_basic (22.01s)
--- PASS: TestAccAWSSSOAdminPermissionSetInlinePolicy_update (41.44s)

@anGie44 anGie44 requested a review from a team as a code owner January 7, 2021 01:19
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 7, 2021
@anGie44 anGie44 added the new-resource Introduces a new resource. label Jan 7, 2021
@anGie44
Copy link
Contributor Author

anGie44 commented Jan 7, 2021

Closing in favor of #15808

@anGie44 anGie44 closed this Jan 7, 2021
@ghost
Copy link

ghost commented Feb 7, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 7, 2021
@anGie44 anGie44 deleted the f-aws-sso-inline-policy branch March 17, 2021 04:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anGie44