Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/mq_broker: support import + plan time validations #11841

Merged
merged 3 commits into from
Apr 24, 2020
Merged

r/mq_broker: support import + plan time validations #11841

merged 3 commits into from
Apr 24, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 31, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource_aws_mq_broker: support import
resource_aws_mq_broker: add plan time validations for `deployment_mode`, `engine_type`, `maintenance_window_start_time.day_of_week`, `user.groups` and `user.username`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSMqBroker_'
--- PASS: TestAccAWSMqBroker_basic (1161.48s)
--- PASS: TestAccAWSMqBroker_allFieldsDefaultVpc (1937.94s)
--- PASS: TestAccAWSMqBroker_allFieldsCustomVpc (1931.77s)
--- PASS: TestAccAWSMqBroker_EncryptionOptions_KmsKeyId (1203.63s)
--- PASS: TestAccAWSMqBroker_EncryptionOptions_UseAwsOwnedKey_Disabled (1231.49s)
--- PASS: TestAccAWSMqBroker_EncryptionOptions_UseAwsOwnedKey_Enabled (1243.31s)
--- PASS: TestAccAWSMqBroker_updateUsers (1568.25s)
--- PASS: TestAccAWSMqBroker_updateTags (1158.33s)
--- PASS: TestAccAWSMqBroker_updateSecurityGroup (1505.76s)
--- PASS: TestAccAWSMqBroker_disappears (1124.52s)

@DrFaust92
add import support
5aa99a2 
use enums
add plan time validations
remove extraneous list tags call
add disappearing test case
@DrFaust92
update arn test
ffbe0c6
@DrFaust92
update docs
50b08ac
@DrFaust92 DrFaust92 requested a review from a team January 31, 2020 20:43
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/mq Issues and PRs that pertain to the mq service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 31, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 25, 2020
anGie44
anGie44 approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @DrFaust92! Waiting on acceptance tests atm

@anGie44
Copy link
Contributor

anGie44 commented Apr 24, 2020

Output from acceptance tests:

--- PASS: TestAccAWSMqBroker_allFieldsCustomVpc (2032.99s)
--- PASS: TestAccAWSMqBroker_EncryptionOptions_UseAwsOwnedKey_Enabled (1171.63s)
--- PASS: TestAccAWSMqBroker_updateTags (1312.44s)
--- PASS: TestAccAWSMqBroker_basic (1434.02s)
--- PASS: TestAccAWSMqBroker_EncryptionOptions_KmsKeyId (1464.17s)
--- PASS: TestAccAWSMqBroker_disappears (1464.58s)
--- PASS: TestAccAWSMqBroker_EncryptionOptions_UseAwsOwnedKey_Disabled (1478.74s)
--- PASS: TestAccAWSMqBroker_updateSecurityGroup (1754.10s)
--- PASS: TestAccAWSMqBroker_allFieldsDefaultVpc (2169.98s)
--- PASS: TestAccAWSMqBroker_updateUsers (2275.43s)

@anGie44 anGie44 modified the milestones: v3.0.0, v2.60.0 Apr 24, 2020
@anGie44 anGie44 merged commit 42e59a3 into hashicorp:master Apr 24, 2020
anGie44 added a commit that referenced this pull request Apr 24, 2020
@anGie44
update CHANGELOG for PR #11841
dcb0096
@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 25, 2020
@DrFaust92 DrFaust92 deleted the r/mq-import branch June 23, 2020 11:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/mq Issues and PRs that pertain to the mq service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.60.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DrFaust92 @anGie44 @bflad