Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Cloud Map resource tagging #13696

Closed
ewbankkit opened this issue Jun 9, 2020 · 4 comments · Fixed by #13750
Closed

AWS Cloud Map resource tagging #13696

ewbankkit opened this issue Jun 9, 2020 · 4 comments · Fixed by #13750
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/servicediscovery Issues and PRs that pertain to the servicediscovery service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Jun 9, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS Cloud Map (AKA ServiceDiscovery) namespaces and services now support resource tags.

New or Affected Resource(s)

Potential Terraform Configuration

resource "aws_service_discovery_private_dns_namespace" "example" {
  tags = {
    Environment = "test"
  }
}

References

Announcement.
Developer Guide.

Requires AWS SDK v1.31.13:

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 9, 2020
@ghost ghost added the service/servicediscovery Issues and PRs that pertain to the servicediscovery service. label Jun 9, 2020
bflad added a commit that referenced this issue Jun 12, 2020
@bflad
Copy link
Contributor

bflad commented Jun 12, 2020

keyvaluetags portion submitted here: #13732

@bflad
Copy link
Contributor

bflad commented Jun 15, 2020

Support for tagging functionality with the Cloud Map resources has been merged and will release with version 2.67.0 of the Terraform AWS Provider, later this week. Thanks to @ewbankkit for the implementation. 👍

@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.67.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/servicediscovery Issues and PRs that pertain to the servicediscovery service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants