Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "go list -m" to get user SDK version in issue template #641

Closed
invidian opened this issue Nov 16, 2020 · 2 comments · Fixed by #671
Closed

Use "go list -m" to get user SDK version in issue template #641

invidian opened this issue Nov 16, 2020 · 2 comments · Fixed by #671
Labels
enhancement New feature or request

Comments

@invidian
Copy link

Currently the following command is suggested to get version of SDK one uses:

go mod edit -json | jq '.Require[] | select(.Path=="github.com/hashicorp/terraform-plugin-sdk/v2")'

However, this requires jq binary and may not be accurate, if one use replace option in go.mod.

I think asking users to run the command below would be better, as it will show which version of SDK is used for building

go list -m github.com/hashicorp/terraform-plugin-sdk/v2

Sample output:

$ go list -m github.com/hashicorp/terraform-plugin-sdk/v2
github.com/hashicorp/terraform-plugin-sdk/v2 v2.2.0

See https://golang.org/ref/mod#go-list-m for more details.
@invidian invidian added the enhancement New feature or request label Nov 16, 2020
paddycarver added a commit that referenced this issue Jan 4, 2021
@paddycarver
Use better command for module version detection.
9fd9f7b 
Update the issue templates to show a command that retrieves the current
version of the module without relying on jq or any other tooling beyond
the `go` command.

Fixes #641.
@paddycarver paddycarver mentioned this issue Jan 4, 2021
Merged
@paddycarver
Copy link
Contributor

Thanks! I like this a lot better than the jq version. I've opened #671 to make these changes.

@kmoe kmoe closed this as completed in #671 Jan 5, 2021
kmoe pushed a commit that referenced this issue Jan 5, 2021
@paddycarver @kmoe
Use better command for module version detection.
05cef0c 
Update the issue templates to show a command that retrieves the current
version of the module without relying on jq or any other tooling beyond
the `go` command.

Fixes #641.
@ghost
Copy link

ghost commented Feb 5, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use better command for module version detection. hashicorp/terraform-plugin-sdk
2 participants
@paddycarver @invidian