Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new setting for early validation #1353

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Aug 7, 2023

Adds validation.earlyValidation as a new setting.

I chose to use validation as a primary key as we expect to add future settings for this feature.

@jpogran jpogran self-assigned this Aug 7, 2023
@jpogran jpogran linked an issue Aug 7, 2023 that may be closed by this pull request
Adds `validation.earlyValidation` as a new setting.

I chose to use `validation` as a primary key as we expect to add future settings for this feature.
@jpogran jpogran force-pushed the early_validation_setting branch from c5308ad to c6dccfd Compare August 8, 2023 15:13
@jpogran jpogran marked this pull request as ready for review August 8, 2023 15:15
@jpogran jpogran requested a review from a team as a code owner August 8, 2023 15:15
@radeksimko radeksimko changed the base branch from main to f-early-validation August 8, 2023 16:11
@radeksimko radeksimko merged commit 4f3c074 into f-early-validation Aug 8, 2023
@radeksimko radeksimko deleted the early_validation_setting branch August 8, 2023 16:11
jpogran added a commit that referenced this pull request Aug 10, 2023
Adds `validation.earlyValidation` as a new setting.

I chose to use `validation` as a primary key as we expect to add future settings for this feature.
dbanck pushed a commit that referenced this pull request Aug 22, 2023
Adds `validation.earlyValidation` as a new setting.

I chose to use `validation` as a primary key as we expect to add future settings for this feature.
dbanck pushed a commit that referenced this pull request Aug 29, 2023
Adds `validation.earlyValidation` as a new setting.

I chose to use `validation` as a primary key as we expect to add future settings for this feature.
dbanck pushed a commit that referenced this pull request Aug 31, 2023
Adds `validation.earlyValidation` as a new setting.

I chose to use `validation` as a primary key as we expect to add future settings for this feature.
radeksimko pushed a commit that referenced this pull request Sep 4, 2023
Adds `validation.earlyValidation` as a new setting.

I chose to use `validation` as a primary key as we expect to add future settings for this feature.
dbanck pushed a commit that referenced this pull request Sep 7, 2023
Adds `validation.earlyValidation` as a new setting.

I chose to use `validation` as a primary key as we expect to add future settings for this feature.
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a new setting to toggle early validation
2 participants