indexer: Account for module calls pointing outside of the workspace #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a54fe37 to
00936de
Compare
1294a30 to
ea18a9c
Compare
2 tasks
2044b5d to
56629c1
Compare
56629c1 to
cca874e
Compare
dbanck
approved these changes
Jul 18, 2022
| @@ -68,6 +69,16 @@ func (idx *Indexer) decodeModule(ctx context.Context, modHandle document.DirHand | |||
| Type: op.OpTypeLoadModuleMetadata.String(), | |||
| Defer: func(ctx context.Context, jobErr error) (job.IDs, error) { | |||
| ids := make(job.IDs, 0) | |||
|
|
|||
| var errs *multierror.Error | |||
There was a problem hiding this comment.
Do we need to return this further down?
|
Closing as per our conversation on Slack, summarized in #996 (comment) |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Fixes #996
I originally started this PR as an attempt to fix a race condition where origins for parent module are collected too early (before the submodule metadata decoding) which causes go-to-definition to not work at first load, but later realized that a reliable fix for that will require us to stop de-duplicating jobs, which in turn will require some other changes, so I created #1002 instead to track that work.
UX Before (on first load)
UX After (on first load)