-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completion/hover/highlighting for variable
default
#537
Labels
enhancement
New feature or request
textDocument/completion
textDocument/hover
textDocument/semanticTokens
Semantic syntax highlighting
Comments
beandrad
added a commit
to aztfmod/terraform-schema
that referenced
this issue
Jun 4, 2021
To support completion/hover/highlighting for variable `default`. As part of this change, the `default` attribute was removed from the variable schema block so that it can be set by the decoder. Related to hashicorp/terraform-ls#537
This was referenced Jun 4, 2021
beandrad
added a commit
to aztfmod/terraform-schema
that referenced
this issue
Jun 4, 2021
To support completion/hover/highlighting for variable `default`. As part of this change, the `default` attribute was removed from the variable schema block so that it can be set by the decoder. Related to hashicorp/terraform-ls#537
radeksimko
pushed a commit
to hashicorp/terraform-schema
that referenced
this issue
Jun 4, 2021
To support completion/hover/highlighting for variable `default`. As part of this change, the `default` attribute was removed from the variable schema block so that it can be set by the decoder. Related to hashicorp/terraform-ls#537
radeksimko
pushed a commit
that referenced
this issue
Jun 10, 2021
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
enhancement
New feature or request
textDocument/completion
textDocument/hover
textDocument/semanticTokens
Semantic syntax highlighting
Will likely depend on #50 or at least on some parts of it.
Use-cases
Completion
Given a config
when user triggers completion in the highlighted position, they are presented with two candidates:
Hover
When user hovers over the expression after
default =
, they will be provided with a relevant popup describing type of the expression. For examplewhen hovering over
{ alpha ... }
they would be presented withmap(string)
.In most cases this would basically be just whatever is in
type
, but iftype = any
,type = list(any)
and similar, the hover popup should reflect the real type inferred from the value (as long as it is compatible).Semantic Tokens
Given a config
"blah"
will be reported as string1
,3
and5
will be reported as numberfoo
will be reported as attribute name"test"
will be reported as stringProposal
*.tfvars
) #50 is implemented as perProposal
section)SetVariables(map[string]module.Variable)
toterraform-schema
/schema.SchemaMerger
schema.LiteralTypeExpr
todefault
attribute of avariable
block via label-drivenDependentBody
. SetIsDepKey: true
for thevariable
block label as part ofSchemaMerger.SchemaForModule
terraform-schema
The text was updated successfully, but these errors were encountered: