Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom type for NestingMode type #30

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Use custom type for NestingMode type #30

merged 1 commit into from
Mar 22, 2021

Conversation

radeksimko
Copy link
Member

The previous implementation was not wrong, but this patch just makes it easier to use NestingMode in a switch statement where string and custom type otherwise cannot be mixed.

@radeksimko radeksimko requested a review from vancluever March 22, 2021 14:52
@radeksimko radeksimko mentioned this pull request Mar 22, 2021
Merged
@radeksimko radeksimko merged commit 10a0ad8 into main Mar 22, 2021
@radeksimko radeksimko deleted the b-correct-attr-nesting-mode-type branch March 22, 2021 17:32
@radeksimko radeksimko mentioned this pull request Mar 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwhooker mwhooker mwhooker approved these changes

@vancluever vancluever Awaiting requested review from vancluever

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @mwhooker