Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: install Go 1.14 on Windows #37

Merged
merged 1 commit into from
Jul 20, 2020
Merged

CI: install Go 1.14 on Windows #37

merged 1 commit into from
Jul 20, 2020

Conversation

kmoe
Copy link
Member

@kmoe kmoe commented Jul 20, 2020 •
edited
Loading

Install Go 1.14.6 on Windows build agents.

@kmoe kmoe force-pushed the ci-windows-go branch 2 times, most recently from 23487cc to 3b4c814 Compare July 20, 2020 12:36
@kmoe kmoe changed the title install go 1.14 on windows CI: install Go 1.14 on Windows Jul 20, 2020
@kmoe kmoe force-pushed the ci-windows-go branch 3 times, most recently from e68316b to 73d56a8 Compare July 20, 2020 12:57
@kmoe kmoe marked this pull request as ready for review July 20, 2020 12:57
@kmoe kmoe requested review from paultyng and radeksimko July 20, 2020 12:58
paultyng
paultyng reviewed Jul 20, 2020
View reviewed changes
paultyng
paultyng previously approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@paultyng paultyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, otherwise LGTM

@kmoe kmoe merged commit fef41dd into master Jul 20, 2020
@kmoe kmoe deleted the ci-windows-go branch July 20, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paultyng paultyng paultyng left review comments

@radeksimko radeksimko Awaiting requested review from radeksimko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmoe @paultyng