Parse the sensitive key for input variables #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alisdair
suggested changes
Nov 15, 2021
tfconfig/load_legacy.go
Outdated
| @@ -110,6 +111,7 @@ func loadModuleLegacyHCL(fs FS, dir string) (*Module, Diagnostics) { | |||
| Description: block.Description, | |||
| Default: block.Default, | |||
| Required: block.Default == nil, | |||
| Sensitive: block.Sensitive, | |||
There was a problem hiding this comment.
I don't think we need these changes in the legacy code path. This should only be hit if there are parsing errors due to pre-0.12 configuration language, and since sensitive variables were introduced much later, trying to parse them here isn't helpful.
If I'm mistaken and it's worth keeping these changes here, can you add test coverage? Tests currently still pass after reverting the changes to this file locally.
There was a problem hiding this comment.
I removed the sensitive property for legacy modules. Rationale seems sound to me!
alisdair
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64.