Expose configuration_aliases from required_providers #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e23e4a7 to
6ae4677
Compare
6ae4677 to
4e9366d
Compare
pselle
approved these changes
Mar 17, 2021
| source, err := kv.Value.Value(nil) | ||
| if err != nil || !source.Type().Equals(cty.String) { | ||
| source, valDiags := kv.Value.Value(nil) | ||
| if valDiags.HasErrors() || !source.Type().Equals(cty.String) { |
mrwacky42
added a commit
to HeadspaceMeditation/terraform-config-inspect
that referenced
this pull request
Feb 15, 2022
* deps: Migrate from github.com/hashicorp/hcl2 to github.com/hashicorp/hcl/v2 (hashicorp#34) Reference: https://github.com/hashicorp/hcl2#experimental-hcl2 * contributing: terraform-config-inspect is feature complete (hashicorp#35) * terraform.required_providers provider source (hashicorp#37) * tfconfig: add parser for new (optional) required_providers syntax This is a breaking change: module.ProviderRequirements is now a map[string]ProviderRequirement instead of map[string][]string, and the json output has changed accordingly. The following syntaxes are now supported: terraform { required_providers { // new syntax "cloud" = { source = "hashicorp/cloud" version = "1.0.0" } // original syntax is also supported "cloud" = "1.0.0" } } * Fix Markdown rendering * Cleanup Readme formatting * Standardize directory for test data Use standard name for fixtures dir per Go conventions https://golang.org/cmd/go/#hdr-Test_packages * Migrate to Circle * fix: disambiguate variable defaults with "empty" values from undefined (hashicorp#24) - Variable struct and json representation now have an explicit `required` field to disambiguate between a variable with a default value which may either be `null` or the variable type's zero value * Merge source across required_providers blocks If multiple terraform.required_providers blocks are in the config, we already merge the version constraints for each provider. We should also merge the source attribute, and warn if there are duplicates. Consider the following configuration: terraform { required_providers { foo = { version = "1.0.0" } } } terraform { required_providers { foo = { source = "abc/foo" } } } Before this commit, this would result in a provider requirement for "foo" with version constraint "1.0.0", but no "source". This commit merges the source attribute from the second block into this requirement. * Multiple provider source attributes is an error Previously we were diagnosing multiple provider different provider source attribute values as a warning, but this is really a configuration error. This commit updates the diagnostic to be an error, and adds a forced failure in the legacy parser when a `required_providers` block is encountered to ensure that the error propagates. * Allow parsing module from any filesystem (hashicorp#49) * Allow parsing from any filesystem * avoid caching parsed files * Expose lower-level hcl.File load function (hashicorp#53) * Support the sensitive attribute on outputs (hashicorp#55) (hashicorp#56) Add a "sensitive" attribute to outputs. If sensitive is not specified or is false it will not be present in the Output object as per omitempty behavior. * tfconfig: decode provider aliases (hashicorp#54) * allow parsing of required_providers containing ref The syntax for configuration_aliases contains bare references to match their use in other parts of the configuration. These however cannot be decoded directly without an EvalContext, as they represent variables. Refactor decodeRequiredProvidersBlock to use the lower level ExprMap function. * Expose configuration_aliases from required_providers (hashicorp#60) * README: The latest releases of this library support the Terraform v0.15 language * README: This library is compatible with the Terraform 1.0 language * README: Updated note about compatibility We now have 1.0 compatibility promises, so we can be more specific in what this library can do. * Parse the sensitive key for input variables * Remove Sensitive property for legacy modules * Update CircleCI config to fix build failures * Give up on 1.11.13, replace with 1.17.3 * update circle config and docker mirror * Fixup after merge Co-authored-by: Brian Flad <bflad417@gmail.com> Co-authored-by: Kristin Laemmert <mildwonkey@users.noreply.github.com> Co-authored-by: Radek Simko <radek.simko@gmail.com> Co-authored-by: Michele <mdeggies@gmail.com> Co-authored-by: Jonathan Stewmon <jstewmon@gmail.com> Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com> Co-authored-by: Andy Caruso <63117216+andy-caruso@users.noreply.github.com> Co-authored-by: James Bardin <j.bardin@gmail.com> Co-authored-by: Martin Atkins <mart@degeneration.co.uk> Co-authored-by: Kyle Carberry <kyle@carberry.com>
kavya498
pushed a commit
to kavya498/terraform-config-inspect
that referenced
this pull request
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unblocks hashicorp/terraform-schema#26 which in turn allows us to support 0.15 configurations and interpret them accurately.
I know that aliases basically don't play any role when it comes to schema (which is what LS cares about), the local name should suffice. However we made a decision in the design of some LS components early on (admittedly with some tradeoffs) to perform exact match on the
providerfields in resources and data source, as opposed to match just first step of the traversal.That decision is not necessarily set in stone, but it would require quite a significant redesign and we'd probably just end up with different trade-offs.