Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lib): expose terraform functions #903

Merged
merged 32 commits into from
Sep 9, 2021
Merged

feat(lib): expose terraform functions #903

merged 32 commits into from
Sep 9, 2021

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Aug 10, 2021 •
edited
Loading

Closes #220

When this is done we should create an issue to improve convert to use the functions

@DanielMSchmidt DanielMSchmidt force-pushed the terraform-functions branch 3 times, most recently from 08b83dc to e241a44 Compare August 10, 2021 18:56
@jsteinich
Copy link
Collaborator

How does jsii handle this approach?

@DanielMSchmidt DanielMSchmidt force-pushed the terraform-functions branch 4 times, most recently from 8bf976c to 253f41c Compare August 12, 2021 13:35
@DanielMSchmidt DanielMSchmidt marked this pull request as ready for review August 12, 2021 14:35
@skorfmann
Copy link
Contributor

FYI: The type export in jsii seems to be a bit picky - see aws/jsii#1818

@DanielMSchmidt DanielMSchmidt force-pushed the terraform-functions branch 3 times, most recently from cb2ff24 to 18c32db Compare August 16, 2021 00:04
@DanielMSchmidt DanielMSchmidt mentioned this pull request Aug 16, 2021
Closed
@DanielMSchmidt DanielMSchmidt force-pushed the terraform-functions branch 2 times, most recently from 67148bc to e16e1d6 Compare August 16, 2021 15:53
jsteinich
jsteinich previously requested changes Aug 17, 2021
View reviewed changes
@DanielMSchmidt DanielMSchmidt force-pushed the terraform-functions branch 3 times, most recently from 2be7e71 to 9dc7e5d Compare August 18, 2021 12:34
This was linked to issues Aug 18, 2021
AzureRM CosmosDB connection_strings[0] yields #{Token[TOKEN.0]} instead of first list item #518
Closed
How to get the list of AZ's of a specific region #374
Closed
@DanielMSchmidt DanielMSchmidt force-pushed the terraform-functions branch 3 times, most recently from dca56c0 to 2a89275 Compare August 18, 2021 14:25
jsteinich
jsteinich reviewed Aug 19, 2021
View reviewed changes
Copy link
Collaborator

@jsteinich jsteinich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't make it through every single function to make sure they are correct. I can keep going on them at a later date, but I think it's important to match how Tokens are used elsewhere. That could be not allowing them as arguments (since they aren't currently allowed in resource) or using them in the same manner as planned (never for strings/numbers and generally always an option for other types). It's important to maintain that consistency.

DanielMSchmidt and others added 17 commits September 9, 2021 16:38
@DanielMSchmidt
fix(lib): handle references better in functions
beed560
@DanielMSchmidt
fix(lib): emit better errors when misusing tokenized arrays
5881bf4 
Arrays can not be dealt with directly when they come as references.
Now that we have a proper way to deal with it we can throw an adequate error.

Fixes #518, #374
@DanielMSchmidt @jsteinich
chore(lib): fix typo
180383f 
Co-authored-by: Jon Steinich <jons@perblue.com>
@DanielMSchmidt
chore(lib): implement review comments
8ad72fb
@DanielMSchmidt
refactor(example): use functions
e4b94ae
@DanielMSchmidt
chore(docs): clarify external inputs
fd7c733
@DanielMSchmidt
refactor(lib): use IResolvable as we do elsewhere
3e58860
@DanielMSchmidt
refactor(lib): rename test case
c7d4eab
@DanielMSchmidt
fix(lib): handle mixed tokens and literals in arrays
27016db
@DanielMSchmidt
fix(lib): make use of ref in locals
349d1a8
@DanielMSchmidt
fix(lib): dont cast boolean IResolvables as boolean
0ac5288
@DanielMSchmidt
fix(lib): improve types
baf6a07
@DanielMSchmidt
fix(docs): explain token system usage
87b7f27
@DanielMSchmidt
fix(cli): don't fail if telemetry fails
5f3e4f2
@DanielMSchmidt
fix(tests): update snapshots
1e0e6e0
@DanielMSchmidt @ansgarm
chore(example): document defaults
9873a35 
Co-authored-by: Ansgar Mertens <ansgar@hashicorp.com>
@DanielMSchmidt
fix(examples): aws provider needs more ram to build on GH actions wit…
b817412 
…h go
@DanielMSchmidt DanielMSchmidt dismissed stale reviews from skorfmann and jsteinich September 9, 2021 20:00

addressed the mentioned issues

@DanielMSchmidt DanielMSchmidt merged commit f35f842 into main Sep 9, 2021
@DanielMSchmidt DanielMSchmidt deleted the terraform-functions branch September 9, 2021 20:03
@jsteinich jsteinich mentioned this pull request Sep 13, 2021
Closed
@skorfmann skorfmann mentioned this pull request Sep 15, 2021
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ansgarm ansgarm ansgarm approved these changes

@skorfmann skorfmann Awaiting requested review from skorfmann

@jsteinich jsteinich Awaiting requested review from jsteinich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6
4 participants
@DanielMSchmidt @jsteinich @skorfmann @ansgarm